[OpenApi] Do not use output for request body#4213
Merged
soyuka merged 2 commits intoApr 25, 2021
Merged
Conversation
Contributor
|
Thanks, note that currently it doesn't fix the second part of the ticket, namely that the generated schema uses jsonld even for the other media types (json, xml...); but maybe we should create a separate issue/PR? |
Member
Author
|
@guilliamxavier Yes another PR would be better (and another issue, I didn't see the second part). |
Contributor
|
I opened #4215, note that the fix depends on this PR |
soyuka
approved these changes
Apr 16, 2021
soyuka
force-pushed
the
fix/open-api-output-request-body
branch
from
426f7eb to
411a09c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the
$schemaobject was reused, the output DTO$refwas not overwritten:core/src/JsonSchema/SchemaFactory.php
Line 95 in d62e86e